search

tidyverts / feasts

Feature Extraction And Statistics for Time Series
https://feasts.tidyverts.org/
291 stars 23 forks source link

Parameter error in gg_season calling scale_x_date #88

Closed ecoughlan closed 4 years ago

ecoughlan commented 4 years ago

I believe this change introduced the following error when the if branch is taken: Error in ggplot2::scale_x_date()$trans$breaks(limit, n = len) : unused argument (n = len) which was probably copied from the similar scale_x_datetime() below. Removing n = len I can plot again. Edit: I assumed wrong, I get the same error on scale_x_datetime(), maybe this is just a version incompatibility.

mitchelloharawild commented 4 years ago

Please update the scales package to the latest CRAN version. I didn't realise this version dependency before submitting the latest version to CRAN, but it is correctly stated in the dev version.

On Thu., 13 Feb. 2020, 19:56 ecoughlan, notifications@github.com wrote:

I believe this change https://github.com/tidyverts/feasts/commit/652d6ea1948f19121e6d9700510f245d93d7103d#diff-6f327c3c21833fe1b104fae42852db90R241 introduced the following error when the if branch is taken: Error in ggplot2::scale_x_date()$trans$breaks(limit, n = len) : unused argument (n = len) which was probably copied from the similar scale_x_datetime() below. Removing n = len I can plot again.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/tidyverts/feasts/issues/88?email_source=notifications&email_token=AD3BJFZAZK7MZXMCKW3P3K3RCURNTA5CNFSM4KUPZPD2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4INHEBPA, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD3BJF34MWTX3U3ONLUQAMLRCURNTANCNFSM4KUPZPDQ .

ecoughlan commented 4 years ago

Confirmed, with scales 1.1.0 everything works. :+1: