search

tidyverts / tsibble

Tidy Temporal Data Frames and Tools
https://tsibble.tidyverts.org
GNU General Public License v3.0
528 stars 50 forks source link

rbind.tbl_ts fails for named arguments #175

Closed mitchelloharawild closed 4 years ago

mitchelloharawild commented 4 years ago

Presumably an identical TRUE comparison for interval within build_tsibble_meta fails due to the named input preserved by map_lgl.

library(tsibble)
ped_split <- split(pedestrian, pedestrian$Sensor)
rbind(a = ped_split[[1]], b = ped_split[[2]])
#> Error: Argument `interval` must be class interval, not logical.

Created on 2020-03-12 by the reprex package (v0.3.0)

earowang commented 4 years ago

now bind_rows() works, and I removed rbind() methods.

mitchelloharawild commented 4 years ago

Any reason to remove rbind() and cbind() methods? Doing so will cause revdep issues.

earowang commented 4 years ago
  1. They are just temporary solutions as bind_rows/cols() are not available before for subclasses.
  2. They produce unpredictable results (e.g. matrix), and I have no control over it.
  3. The forthcoming tsibble release introduces several breaking changes.

Cheers, Earo

On 1 Apr 2020, at 0:21, mitchelloharawild wrote:

Any reason to remove rbind() and cbind() methods? Doing so will cause revdep issues.

-- You are receiving this because you modified the open/close state. Reply to this email directly or view it on GitHub: https://github.com/tidyverts/tsibble/issues/175#issuecomment-606566007