Add fullseq method for year* variants

[mitchelloharawild]

The date_breaks parameter cannot be used with ggplot2 scales for tsibble time classes.

library(tsibble)
#> Warning: package 'tsibble' was built under R version 3.6.3
library(ggplot2)
as_tsibble(USAccDeaths) %>% 
  ggplot(aes(x = index, y = value)) + 
  geom_line() + 
  scale_x_yearmonth(date_breaks = "2 years", date_labels = "%Y")
#> Error in UseMethod("fullseq"): no applicable method for 'fullseq' applied to an object of class "c('yearmonth', 'vctrs_vctr')"

^{Created on 2020-06-18 by the reprex package (v0.3.0)}

[earowang]

Now the arguments are passed to scale_x_continuous(), and _date() doesn’t give nice default breaks anymore. Maybe you can have some suggestions on this.

I’ll submit a patch version soon.

Cheers, Earo

On 18 Jun 2020, at 16:16, mitchelloharawild wrote:

The date_breaks parameter cannot be used with ggplot2 scales for tsibble time classes.

library(tsibble)
#> Warning: package 'tsibble' was built under R version 3.6.3
library(ggplot2)
as_tsibble(USAccDeaths) %>%
  ggplot(aes(x = index, y = value)) +
  geom_line() +
  scale_x_yearmonth(date_breaks = "2 years", date_labels = "%Y")
#> Error in UseMethod("fullseq"): no applicable method for 'fullseq' 
applied to an object of class "c('yearmonth', 'vctrs_vctr')"

^{Created on 2020-06-18 by the reprex package (v0.3.0)}

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/tidyverts/tsibble/issues/198