Closed jmarshallnz closed 3 years ago
Thanks. Looks great! Can you send a new PR on fixing seq.yearquarter()
and seq.yearweek()
with a couple of unit tests? Please add yourself to one of our contributors in the PR too.
Sure, happy to do so over the weekend.
Currently if a
yearmonth
column is present in atsibble
, usingseq
on it without specifyingby
results in an errorDue to
seq.yearmonth()
callingbad_by(by)
.However, the
by
argument is not required byseq
generally (aslength.out
could be instead) and nor is it required forseq.yearmonth
(orseq.yearquarter
).There may be a more elegant method of fixing this, but I figure having a potential fix is better than not! I'm happy to reimplement however you like (and do the same for
seq.yearquarter
as necessary).