tidyverts / tsibble

Tidy Temporal Data Frames and Tools
https://tsibble.tidyverts.org
GNU General Public License v3.0
528 stars 50 forks source link

yearmonth parsing error in v1.0.0 #250

Closed edoardomichielon closed 3 years ago

edoardomichielon commented 3 years ago

In the new version of tsibble 1.0.0 there is an error in yearmonth() parsing function. The error is on November and December months only, when the data has format YYYY-MM,

see example below

Note In version 0.9.3 it worked just fine

require(tsibble)
#> Loading required package: tsibble
#> 
#> Attaching package: 'tsibble'
#> The following objects are masked from 'package:base':
#> 
#>     intersect, setdiff, union

yearmonth(c("2020 Sep", "2020-09"))
#> <yearmonth[2]>
#> [1] "2020 Sep" "2020 Sep"
yearmonth(c("2020 Oct", "2020-10"))
#> <yearmonth[2]>
#> [1] "2020 Oct" "2020 Oct"
yearmonth(c("2020 Nov", "2020-11"))
#> <yearmonth[2]>
#> [1] "2020 Nov" "2020 Jan"
yearmonth(c("2020 Dec", "2020-12"))
#> <yearmonth[2]>
#> [1] "2020 Dec" "2020 Feb"

Created on 2021-02-23 by the reprex package (v0.3.0)

Session info ``` r devtools::session_info() #> ─ Session info ─────────────────────────────────────────────────────────────── #> setting value #> version R version 3.6.3 (2020-02-29) #> os Ubuntu 18.04.4 LTS #> system x86_64, linux-gnu #> ui X11 #> language (EN) #> collate C.UTF-8 #> ctype C.UTF-8 #> tz Etc/UTC #> date 2021-02-23 #> #> ─ Packages ─────────────────────────────────────────────────────────────────── #> package * version date lib source #> anytime 0.3.9 2020-08-27 [4] CRAN (R 3.6.3) #> assertthat 0.2.1 2019-03-21 [4] CRAN (R 3.6.3) #> backports 1.1.8 2020-06-17 [4] CRAN (R 3.6.3) #> callr 3.4.3 2020-03-28 [4] CRAN (R 3.6.3) #> cli 2.0.2 2020-02-28 [4] CRAN (R 3.6.3) #> crayon 1.3.4 2017-09-16 [4] CRAN (R 3.6.3) #> desc 1.2.0 2018-05-01 [4] CRAN (R 3.6.3) #> devtools 2.3.0 2020-04-10 [4] CRAN (R 3.6.3) #> digest 0.6.25 2020-02-23 [4] CRAN (R 3.6.3) #> dplyr 1.0.2 2020-08-18 [1] CRAN (R 3.6.3) #> ellipsis 0.3.1 2020-05-15 [4] CRAN (R 3.6.3) #> evaluate 0.14 2019-05-28 [4] CRAN (R 3.6.3) #> fansi 0.4.1 2020-01-08 [4] CRAN (R 3.6.3) #> fs 1.4.2 2020-06-30 [4] CRAN (R 3.6.3) #> generics 0.0.2 2018-11-29 [4] CRAN (R 3.6.3) #> glue 1.4.1 2020-05-13 [4] CRAN (R 3.6.3) #> highr 0.8 2019-03-20 [4] CRAN (R 3.6.3) #> htmltools 0.5.0 2020-06-16 [4] CRAN (R 3.6.3) #> knitr 1.29 2020-06-23 [4] CRAN (R 3.6.3) #> lifecycle 0.2.0 2020-03-06 [4] CRAN (R 3.6.3) #> lubridate 1.7.9 2020-06-08 [4] CRAN (R 3.6.3) #> magrittr 2.0.1 2020-11-17 [1] CRAN (R 3.6.3) #> memoise 1.1.0 2017-04-21 [4] CRAN (R 3.6.3) #> pillar 1.4.6 2020-07-10 [4] CRAN (R 3.6.3) #> pkgbuild 1.0.8 2020-05-07 [4] CRAN (R 3.6.3) #> pkgconfig 2.0.3 2019-09-22 [4] CRAN (R 3.6.3) #> pkgload 1.1.0 2020-05-29 [4] CRAN (R 3.6.3) #> prettyunits 1.1.1 2020-01-24 [4] CRAN (R 3.6.3) #> processx 3.4.3 2020-07-05 [4] CRAN (R 3.6.3) #> ps 1.3.3 2020-05-08 [4] CRAN (R 3.6.3) #> purrr 0.3.4 2020-04-17 [4] CRAN (R 3.6.3) #> R6 2.4.1 2019-11-12 [4] CRAN (R 3.6.3) #> Rcpp 1.0.5 2020-07-06 [4] CRAN (R 3.6.3) #> remotes 2.1.1 2020-02-15 [4] CRAN (R 3.6.3) #> rlang 0.4.7 2020-07-09 [4] CRAN (R 3.6.3) #> rmarkdown 2.3 2020-06-18 [4] CRAN (R 3.6.3) #> rprojroot 1.3-2 2018-01-03 [4] CRAN (R 3.6.3) #> sessioninfo 1.1.1 2018-11-05 [4] CRAN (R 3.6.3) #> stringi 1.4.6 2020-02-17 [4] CRAN (R 3.6.3) #> stringr 1.4.0 2019-02-10 [4] CRAN (R 3.6.3) #> testthat 2.3.2 2020-03-02 [4] CRAN (R 3.6.3) #> tibble 3.0.3 2020-07-10 [4] CRAN (R 3.6.3) #> tidyselect 1.1.0 2020-05-11 [4] CRAN (R 3.6.3) #> tsibble * 1.0.0 2021-02-20 [1] CRAN (R 3.6.3) #> usethis 1.6.1 2020-04-29 [4] CRAN (R 3.6.3) #> vctrs 0.3.4 2020-08-29 [1] CRAN (R 3.6.3) #> withr 2.2.0 2020-04-20 [4] CRAN (R 3.6.3) #> xfun 0.15 2020-06-21 [4] CRAN (R 3.6.3) #> yaml 2.2.1 2020-02-01 [4] CRAN (R 3.6.3) #> #> [1] /home/edomi/R/x86_64-pc-linux-gnu-library/3.6 #> [2] /usr/local/lib/R/site-library #> [3] /usr/lib/R/site-library #> [4] /usr/lib/R/library ```
edoardobassett commented 3 years ago

Having the same issue. One thing I wanted to note is that in my case, the bug persists in every tsibble version.