search

tidyverts / tsibble

Tidy Temporal Data Frames and Tools
https://tsibble.tidyverts.org
GNU General Public License v3.0
527 stars 49 forks source link

Support for `stats::start()` and `stats::end()` in `fill_gaps()` #269

Closed wkdavis closed 2 years ago

wkdavis commented 2 years ago

The checks for the .full argument of fill_gaps() don't support using stats::start() and stats::end()

https://github.com/tidyverts/tsibble/blob/bfeae843f56328645a188a0c4acef1598b285f99/R/gaps.R#L167

https://github.com/tidyverts/tsibble/blob/bfeae843f56328645a188a0c4acef1598b285f99/R/gaps.R#L171

which necessitates using #' @importFrom stats start end if fill_gaps() is being used inside another package.

Conceptually it seems like a minor change but I couldn't think of an elegant solution. Is this something you would be willing to support?

earowang commented 2 years ago

Thanks. Fixed.

wkdavis commented 2 years ago

Thank you!