create testing file structure

[htwight]

Alright, can I still have a pull request with the new folders so we're on the same page for testing, or should I submit another pull request once I have some other things done.

On Tue, Feb 12, 2019, 11:35 PM Michael Haas <notifications@github.com wrote:

@TripleFrequency requested changes on this pull request.

There really shouldn't be a PR just to add stubs, it dirties the code base unnecessarily.

In app/src/test/kotlin/io/imhungry/di/AppModuleTest.kt https://github.com/tiemonl/imhungry/pull/4#discussion_r256244588:

@@ -0,0 +1,4 @@ +package io.imhungry.di + +class AppModuleTest { +}

You don't write tests for dependency injection components.

In app/src/test/kotlin/io/imhungry/di/RoomModuleTest.kt https://github.com/tiemonl/imhungry/pull/4#discussion_r256244622:

@@ -0,0 +1,4 @@ +package io.imhungry.di + +class RoomModuleTest { +}

Same here, no tests for dependency injection needed

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tiemonl/imhungry/pull/4#pullrequestreview-203025754, or mute the thread https://github.com/notifications/unsubscribe-auth/AIOFekIh1diHK7kVE46wCbnQ24moE3ZMks5vM5X_gaJpZM4a4lew .

[TripleFrequency]

Empty folders are not included in commits, so you can't add the folders without files. Beyond that, you should include these files only once they contain content.

As far as testing is concerned, I think setting this standard is fine, but tests are automatically placed in the same locations as these files whenever you generate them in the IDE. If people don't do that, it will hopefully get caught in a code review.

I don't believe this needs its own PR at this point.