search

tiemonl / imhungry

imhungry is an Android app to decide where to eat any time, any where
https://imhungry.io/
GNU General Public License v3.0
1 stars 0 forks source link

GH-48: Only send welcome notification on login #53

Closed lcombs15 closed 5 years ago

lcombs15 commented 5 years ago

Resolves GH-48

This only shows after successful login now: image

lcombs15 commented 5 years ago

@tiemonl Would you locally merge this change with your #28 and make sure everything is all good?

TripleFrequency commented 5 years ago

@lcombs15 Just merge yours, we'll look at any conflicts with #28 after.

lcombs15 commented 5 years ago

@TripleFrequency His changes in #28 are how #48 got started. I'm not worried about code conflicts, I'm worried about functionality.

TripleFrequency commented 5 years ago

It won't be a problem. The functionality of the nav bar just launches various activities. Given you had the notification in onStart, we were making several instances of the HomeActivity, while before we only had the one.

lcombs15 commented 5 years ago

Okay, that fine with me.