search

tiemonl / imhungry

imhungry is an Android app to decide where to eat any time, any where
https://imhungry.io/
GNU General Public License v3.0
1 stars 0 forks source link

GH-47: Begin refactor of maps #73

Closed TripleFrequency closed 5 years ago

TripleFrequency commented 5 years ago

This does some of the early work for the map refactor. These are the changes seen in the midterm milestone, and not much more. I cleaned things up a little bit, but ultimately this will have a few hacks to it until #45 sees some serious progress.

Once we have proper caching and a better interface for accessing Places API data, this solution can be cleaned up a lot, and we can do much more.

I left a couple TODO comments in both the layout files and adapter code, which is some points that will need attention (one being UI and another being something that simply isn't a priority, especially since we will be able to simplify that once our cache is more powerful).

image

codecov[bot] commented 5 years ago

Codecov Report

Merging #73 into master will not change coverage. The diff coverage is 0%.

Impacted file tree graph

@@         Coverage Diff          @@
##           master   #73   +/-   ##
====================================
  Coverage       0%    0%           
====================================
  Files          28    29    +1     
  Lines         338   395   +57     
  Branches       41    49    +8     
====================================
- Misses        338   395   +57
Impacted Files Coverage Δ
...io/imhungry/maps/ui/adapters/PlacesImageAdapter.kt 0% <0%> (ø)
...lin/io/imhungry/maps/ui/adapters/MapItemAdapter.kt 0% <0%> (ø) :arrow_up:
...rc/main/kotlin/io/imhungry/maps/vm/MapViewModel.kt 0% <0%> (ø) :arrow_up:
...src/main/kotlin/io/imhungry/maps/ui/MapActivity.kt 0% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2b100d5...85572a8. Read the comment docs.