fix(lidar-lidar-calib): fix crash when passing point cloud with zero points

tier4 / CalibrationTools

sensor calibration tools for autonomous driving and robotics

GNU General Public License v3.0

121 stars 44 forks source link

Description

Fixed bugs that occurred when the version of ros2 was upgraded to humble.

Fix issue causing crash when passing point cloud with zero points to PCL's transformPointCloud
- I have added the task of displaying the service status of each sensor frame in the terminal.
Fix service client crash by updating humble
Fix a problem the number of point clouds is less than 3 when calculating pca
Related links

https://tier4.atlassian.net/browse/AEAP-546

Tests performed

Try inputting a zero point cloud and confirm that no calibration nodes have fallen.
Using rosbag, I confirmed that calibration result is equivalent to previous version.

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.
[ ] The PR has been properly tested.
[ ] The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Codecov Report

:exclamation: No coverage uploaded for pull request base (beta/v2022.07.1@287d002). Click here to learn what that means. Patch has no changes to coverable lines.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## beta/v2022.07.1 #111 +/- ## ================================================= Coverage ? 0.00% ================================================= Files ? 8 Lines ? 495 Branches ? 0 ================================================= Hits ? 0 Misses ? 495 Partials ? 0 ``` | Flag | Coverage Δ | | |---|---|---| | differential | `0.00% <0.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tier4#carryforward-flags-in-the-pull-request-comment) to find out more.

tier4 / CalibrationTools