search

tier4 / CalibrationTools

GNU General Public License v3.0
98 stars 35 forks source link

fix(calibration_tools): fixed compile error and ci/cd #127

Closed knzo25 closed 9 months ago

knzo25 commented 9 months ago

Description

As per the title

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

After all checkboxes are checked, anyone who has write access can merge the PR.

knzo25 commented 9 months ago

@bgilby59 Thanks for the catch !

codecov-commenter commented 9 months ago

Codecov Report

Patch coverage has no change and project coverage change: -1.02% :warning:

Comparison is base (4883468) 1.01% compared to head (dbb024a) 0.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## tier4/universe #127 +/- ## ================================================= - Coverage 1.01% 0.00% -1.02% ================================================= Files 262 76 -186 Lines 20040 8551 -11489 Branches 387 0 -387 ================================================= - Hits 203 0 -203 + Misses 19683 8551 -11132 + Partials 154 0 -154 ``` | [Flag](https://app.codecov.io/gh/tier4/CalibrationTools/pull/127/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tier4) | Coverage Δ | | |---|---|---| | [differential](https://app.codecov.io/gh/tier4/CalibrationTools/pull/127/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tier4) | `0.00% <0.00%> (?)` | | | [total](https://app.codecov.io/gh/tier4/CalibrationTools/pull/127/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tier4) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tier4#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/tier4/CalibrationTools/pull/127?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tier4) | Coverage Δ | | |---|---|---| | [...\_calibration\_pcl\_extensions/joint\_icp\_extended.hpp](https://app.codecov.io/gh/tier4/CalibrationTools/pull/127?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tier4#diff-Y29tbW9uL3RpZXI0X2NhbGlicmF0aW9uX3BjbF9leHRlbnNpb25zL2luY2x1ZGUvdGllcjRfY2FsaWJyYXRpb25fcGNsX2V4dGVuc2lvbnMvam9pbnRfaWNwX2V4dGVuZGVkLmhwcA==) | `0.00% <ø> (ø)` | | | [...bration\_pcl\_extensions/joint\_icp\_extended\_impl.hpp](https://app.codecov.io/gh/tier4/CalibrationTools/pull/127?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tier4#diff-Y29tbW9uL3RpZXI0X2NhbGlicmF0aW9uX3BjbF9leHRlbnNpb25zL2luY2x1ZGUvdGllcjRfY2FsaWJyYXRpb25fcGNsX2V4dGVuc2lvbnMvam9pbnRfaWNwX2V4dGVuZGVkX2ltcGwuaHBw) | `0.00% <ø> (ø)` | | | [...calibration\_pcl\_extensions/voxel\_grid\_triplets.hpp](https://app.codecov.io/gh/tier4/CalibrationTools/pull/127?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tier4#diff-Y29tbW9uL3RpZXI0X2NhbGlicmF0aW9uX3BjbF9leHRlbnNpb25zL2luY2x1ZGUvdGllcjRfY2FsaWJyYXRpb25fcGNsX2V4dGVuc2lvbnMvdm94ZWxfZ3JpZF90cmlwbGV0cy5ocHA=) | `0.00% <ø> (ø)` | | | [...ration\_pcl\_extensions/voxel\_grid\_triplets\_impl.hpp](https://app.codecov.io/gh/tier4/CalibrationTools/pull/127?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tier4#diff-Y29tbW9uL3RpZXI0X2NhbGlicmF0aW9uX3BjbF9leHRlbnNpb25zL2luY2x1ZGUvdGllcjRfY2FsaWJyYXRpb25fcGNsX2V4dGVuc2lvbnMvdm94ZWxfZ3JpZF90cmlwbGV0c19pbXBsLmhwcA==) | `0.00% <ø> (ø)` | | | [...ls/include/tier4\_tag\_utils/apriltag\_hypothesis.hpp](https://app.codecov.io/gh/tier4/CalibrationTools/pull/127?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tier4#diff-Y29tbW9uL3RpZXI0X3RhZ191dGlscy9pbmNsdWRlL3RpZXI0X3RhZ191dGlscy9hcHJpbHRhZ19oeXBvdGhlc2lzLmhwcA==) | `0.00% <ø> (ø)` | | | [...ls/include/tier4\_tag\_utils/lidartag\_hypothesis.hpp](https://app.codecov.io/gh/tier4/CalibrationTools/pull/127?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tier4#diff-Y29tbW9uL3RpZXI0X3RhZ191dGlscy9pbmNsdWRlL3RpZXI0X3RhZ191dGlscy9saWRhcnRhZ19oeXBvdGhlc2lzLmhwcA==) | `0.00% <ø> (ø)` | | | [common/tier4\_tag\_utils/src/apriltag\_filter.cpp](https://app.codecov.io/gh/tier4/CalibrationTools/pull/127?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tier4#diff-Y29tbW9uL3RpZXI0X3RhZ191dGlscy9zcmMvYXByaWx0YWdfZmlsdGVyLmNwcA==) | `0.00% <ø> (ø)` | | | [common/tier4\_tag\_utils/src/apriltag\_hypothesis.cpp](https://app.codecov.io/gh/tier4/CalibrationTools/pull/127?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tier4#diff-Y29tbW9uL3RpZXI0X3RhZ191dGlscy9zcmMvYXByaWx0YWdfaHlwb3RoZXNpcy5jcHA=) | `0.00% <ø> (ø)` | | | [common/tier4\_tag\_utils/src/lidartag\_filter.cpp](https://app.codecov.io/gh/tier4/CalibrationTools/pull/127?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tier4#diff-Y29tbW9uL3RpZXI0X3RhZ191dGlscy9zcmMvbGlkYXJ0YWdfZmlsdGVyLmNwcA==) | `0.00% <ø> (ø)` | | | [common/tier4\_tag\_utils/src/lidartag\_hypothesis.cpp](https://app.codecov.io/gh/tier4/CalibrationTools/pull/127?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tier4#diff-Y29tbW9uL3RpZXI0X3RhZ191dGlscy9zcmMvbGlkYXJ0YWdfaHlwb3RoZXNpcy5jcHA=) | `0.00% <ø> (ø)` | | | ... and [44 more](https://app.codecov.io/gh/tier4/CalibrationTools/pull/127?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tier4) | | ... and [186 files with indirect coverage changes](https://app.codecov.io/gh/tier4/CalibrationTools/pull/127/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tier4)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

knzo25 commented 9 months ago

I have been dreading addressing the spelling since last december, when we started having those appear in pre-commit I have planned to address them after the inevitable refactor that comes with the new API (starting before the end of this month?)