tier4 / CalibrationTools

sensor calibration tools for autonomous driving and robotics
GNU General Public License v3.0
121 stars 44 forks source link

fix(gyro_bias_module): small fix about x,y,z #133

Closed SakodaShintaro closed 1 year ago

SakodaShintaro commented 1 year ago

Description

Fixed a small mistake regarding axes.

Related links

Tests performed

$ colcon build --packages-select deviation_estimator
Starting >>> deviation_estimator
[Processing: deviation_estimator]                             
Finished <<< deviation_estimator [54.3s]                       

Summary: 1 package finished [56.0s]

$ colcon test --packages-select deviation_estimator
Starting >>> deviation_estimator
Finished <<< deviation_estimator [5.83s]          

Summary: 1 package finished [7.17s]

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

After all checkboxes are checked, anyone who has write access can merge the PR.

codecov-commenter commented 1 year ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (8b5c007) 0.97% compared to head (0c80896) 19.31%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## tier4/universe #133 +/- ## =================================================== + Coverage 0.97% 19.31% +18.34% =================================================== Files 269 14 -255 Lines 20904 554 -20350 Branches 387 301 -86 =================================================== - Hits 203 107 -96 + Misses 20547 372 -20175 + Partials 154 75 -79 ``` | [Flag](https://app.codecov.io/gh/tier4/CalibrationTools/pull/133/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tier4) | Coverage Δ | | |---|---|---| | [differential](https://app.codecov.io/gh/tier4/CalibrationTools/pull/133/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tier4) | `19.31% <33.33%> (?)` | | | [total](https://app.codecov.io/gh/tier4/CalibrationTools/pull/133/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tier4) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tier4#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/tier4/CalibrationTools/pull/133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tier4) | Coverage Δ | | |---|---|---| | [...tools/deviation\_estimator/src/gyro\_bias\_module.cpp](https://app.codecov.io/gh/tier4/CalibrationTools/pull/133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tier4#diff-bG9jYWxpemF0aW9uL2RldmlhdGlvbl9lc3RpbWF0aW9uX3Rvb2xzL2RldmlhdGlvbl9lc3RpbWF0b3Ivc3JjL2d5cm9fYmlhc19tb2R1bGUuY3Bw) | `44.18% <33.33%> (-2.16%)` | :arrow_down: | ... and [255 files with indirect coverage changes](https://app.codecov.io/gh/tier4/CalibrationTools/pull/133/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tier4)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.