fix(deviation_evaluator): fix bug in map launch and plot

kminoda commented 8 months ago

Description

Fix map launch for incorporating latest map launching configuration
Fix ignoring configuration for plotting the expected errors

Tests performed

Launched deviation_evaluator and confirmed that the outputs are properly generated.

Notes for reviewers

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.
[ ] The PR has been properly tested.
[ ] The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b0153ee) 0.95% compared to head (7b9f40c) 0.00%. Report is 1 commits behind head on tier4/universe.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## tier4/universe #143 +/- ## ================================================= - Coverage 0.95% 0.00% -0.96% ================================================= Files 269 4 -265 Lines 20908 142 -20766 Branches 387 0 -387 ================================================= - Hits 200 0 -200 + Misses 20551 142 -20409 + Partials 157 0 -157 ``` | [Flag](https://app.codecov.io/gh/tier4/CalibrationTools/pull/143/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tier4) | Coverage Δ | | |---|---|---| | [differential](https://app.codecov.io/gh/tier4/CalibrationTools/pull/143/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tier4) | `0.00% <ø> (?)` | | | [total](https://app.codecov.io/gh/tier4/CalibrationTools/pull/143/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tier4) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tier4#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

YamatoAndo commented 8 months ago

LGTM but please fix the CI/CD's error

kminoda commented 8 months ago

@YamatoAndo Thank you, fixed: https://github.com/tier4/CalibrationTools/pull/143/commits/7b9f40c18c554b231a4f8fbc09460d6c83eaac55

tier4 / CalibrationTools