tier4 / CalibrationTools

sensor calibration tools for autonomous driving and robotics
GNU General Public License v3.0
111 stars 41 forks source link

fix(extrinsic_tag_based_base_calibrator): fixed viz callback in case some detections get lost #146

Closed knzo25 closed 10 months ago

knzo25 commented 10 months ago

Description

fixed viz callback in case some detections get lost due to inconsistencies

Related links

TIER IV INTERNAL LINK

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

After all checkboxes are checked, anyone who has write access can merge the PR.

codecov-commenter commented 10 months ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (b0153ee) 0.95% compared to head (6b24dde) 0.00%. Report is 3 commits behind head on tier4/universe.

Files Patch % Lines
...brator/src/extrinsic_tag_based_base_calibrator.cpp 0.00% 4 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## tier4/universe #146 +/- ## ================================================= - Coverage 0.95% 0.00% -0.96% ================================================= Files 269 21 -248 Lines 20908 2425 -18483 Branches 387 0 -387 ================================================= - Hits 200 0 -200 + Misses 20551 2425 -18126 + Partials 157 0 -157 ``` | [Flag](https://app.codecov.io/gh/tier4/CalibrationTools/pull/146/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tier4) | Coverage Δ | | |---|---|---| | [differential](https://app.codecov.io/gh/tier4/CalibrationTools/pull/146/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tier4) | `0.00% <0.00%> (?)` | | | [total](https://app.codecov.io/gh/tier4/CalibrationTools/pull/146/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tier4) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tier4#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.