Closed SakodaShintaro closed 10 months ago
Attention: 185 lines
in your changes are missing coverage. Please review.
Comparison is base (
6af0d0d
) 0.94% compared to head (9dc9794
) 14.09%.
Files | Patch % | Lines |
---|---|---|
...viation_estimator/src/deviation_estimator_main.cpp | 0.00% | 185 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
I created a unit tool of
deviation_estimator
that loads rosbag and performs calibration.Context
The current
deviation_estimator
is implemented as a ros2 node, so it takes the same amount of time as the rosbag used for calibration.Also, since it is a ros2 node, there is a problem that slight variations occur depending on the execution, making it impossible to reproduce same results.
By implementing it as a unit tool that directly loads rosbag, it runs in seconds and deterministically.
I think migration (removal of ros2 node version and rewriting of README) will be done in another PR in the future.
Tests performed
I ran
deviation_estimator
on several rosbags and confirmed that results close to conventional ones were obtained.Example
as a ros2 node
as a unit tool
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.