tier4 / CalibrationTools

GNU General Public License v3.0
98 stars 35 forks source link

fix(deviation_estimator): fixed as pointed out by linter #150

Closed SakodaShintaro closed 5 months ago

SakodaShintaro commented 5 months ago

Description

Fixed as pointed out by linter

https://results.pre-commit.ci/run/github/510948608/1705567553.YYHly4IdQg642vuwD1Q_gg

Tests performed

It has been confirmed that using unit_tool gives exactly the same results as before.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

After all checkboxes are checked, anyone who has write access can merge the PR.

codecov-commenter commented 5 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (df312f4) 0.93% compared to head (838e882) 11.81%.

Files Patch % Lines
...nclude/deviation_evaluator/deviation_evaluator.hpp 0.00% 1 Missing :warning:
...ls/deviation_evaluator/src/deviation_evaluator.cpp 0.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## tier4/universe #150 +/- ## =================================================== + Coverage 0.93% 11.81% +10.88% =================================================== Files 270 19 -251 Lines 21339 880 -20459 Branches 383 297 -86 =================================================== - Hits 200 104 -96 + Misses 20982 698 -20284 + Partials 157 78 -79 ``` | [Flag](https://app.codecov.io/gh/tier4/CalibrationTools/pull/150/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tier4) | Coverage Δ | | |---|---|---| | [differential](https://app.codecov.io/gh/tier4/CalibrationTools/pull/150/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tier4) | `11.81% <0.00%> (?)` | | | [total](https://app.codecov.io/gh/tier4/CalibrationTools/pull/150/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tier4) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tier4#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.