tier4 / CalibrationTools

sensor calibration tools for autonomous driving and robotics
GNU General Public License v3.0
121 stars 44 forks source link

feat: subsampled + roi approach to accelerate intrinsic calibration #152

Closed knzo25 closed 5 months ago

knzo25 commented 10 months ago

Description

With high resolution cameras the intrinsic tools ran very slow. To avoid / remedy that we can use a two detection step:

Related links

Tests performed

Notes for reviewers

We need to test:

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

After all checkboxes are checked, anyone who has write access can merge the PR.

knzo25 commented 5 months ago

Confirmed that the detections' pixel coordinates are the same using the ROI approach and the while image using a perfect image Checkerboard_20240621_131154

knzo25 commented 5 months ago

@amadeuszsz Could you detail the experiments you did here just in case? (and add your review when possible)

I also added you as approver in the old related ticker TIER IV INTERNAL LINK

PS: there are pre-commit errors but those are being handled elsewhere