Closed knzo25 closed 7 months ago
@vividf Did you confirm that the changes fixes the issues on your environment? (the two issues this PR addresses)
@knzo25 Yes, the button will be enabled even /tf comes later, also all of the processes are killed.
@vividf Thanks for the check !
Description
Upon the release of the new api, two problems were encountered:
Related links
Tickets:
Tests performed
After the
Launcher configuration
widget, the sensor calibration manager executes the respective launchers. In this condition, even if we close the sensor calibration manager via widget or console, no zombies remain(can be checked with
ps -aux | grep ros
) or similarPreviously, if we ran the sensor calibration manager until after the launchers were executed with no autoware nor rosbag (which publishes the /tf_static), even if we started autoware or the rosbag afterwards, the calibration tool never became able to calibrate due to the design of the internal state machine. With this PR, is should be fixed
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.