tier4 / CalibrationTools

sensor calibration tools for autonomous driving and robotics
GNU General Public License v3.0
121 stars 44 forks source link

fix(mapping_based_calibrator): typo in the lidar-lidar calibrator #211

Closed knzo25 closed 2 weeks ago

knzo25 commented 3 weeks ago

Description

As pointed in https://github.com/tier4/CalibrationTools/issues/209, the checkKeyframeLost was wrongly computed due to a typo that ignored one of the conditions. This PR addresses that issue.

Related links

Issue: https://github.com/tier4/CalibrationTools/issues/209

Tests performed

None

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

After all checkboxes are checked, anyone who has write access can merge the PR.

codecov-commenter commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (bab5400) to head (2334c0e). Report is 25 commits behind head on tier4/universe.

Files with missing lines Patch % Lines
...apping_based_calibrator/src/calibration_mapper.cpp 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## tier4/universe #211 +/- ## ================================================= - Coverage 0.93% 0.00% -0.94% ================================================= Files 270 28 -242 Lines 21339 2653 -18686 Branches 383 223 -160 ================================================= - Hits 200 0 -200 + Misses 20982 2653 -18329 + Partials 157 0 -157 ``` | [Flag](https://app.codecov.io/gh/tier4/CalibrationTools/pull/211/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tier4) | Coverage Δ | | |---|---|---| | [differential](https://app.codecov.io/gh/tier4/CalibrationTools/pull/211/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tier4) | `0.00% <0.00%> (?)` | | | [total](https://app.codecov.io/gh/tier4/CalibrationTools/pull/211/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tier4) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tier4#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.