chore: sync tier4/universe

[yabuta]

Description

sync tier4/universe

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• [x] I've confirmed the contribution guidelines.
• [x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• [ ] The PR follows the pull request guidelines.
• [ ] The PR has been properly tested.
• [ ] The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• [ ] There are no open discussions or they are tracked via tickets.
• [ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

[wep21]

@yabuta cc @kenji-miyake could you make semantic-pull-request required and enable pre-commit.ci?

[kenji-miyake]

pre-commit.ci run -> It seems it requires admin right. :pleading_face:

[yabuta]

I change Title and semantic-pull-request is OK. @wep21 @kenji-miyake Sorry, do you know why pre-commit.ci is skipped?

[kenji-miyake]

You have to install the app from https://pre-commit.ci/.

[kenji-miyake]

I change Title and semantic-pull-request is OK.

Thanks, but I guess he requested to set the CI check Required from the branch protection rule.

[yabuta]

@wep21 I add pre-commit.ci and it is shown some error. But if fix this error in this PR, there will be a lot of changes that is not related with sync. So I fix this error in other PR.

[yabuta]

@knzo25 Do you have more comment?

[wep21]

I also recommend to force to do a squash merge by setting.

[knzo25]

@knzo25 Do you have more comment?

No, LGTM!

[kenji-miyake]

If Clang-Tidy is noisy, please disable this workflow. https://github.com/tier4/CalibrationTools/actions/workflows/clang-tidy-pr-comments.yaml