fix(extrinsic_tag_based_calibrator): mismatch between rviz and topics (xx1 - camera5) - Githubissues

tier4 / CalibrationTools

sensor calibration tools for autonomous driving and robotics

GNU General Public License v3.0

121 stars 44 forks source link

fix(extrinsic_tag_based_calibrator): mismatch between rviz and topics (xx1 - camera5) #28

Closed knzo25 closed 2 years ago

knzo25 commented 2 years ago

Description

The rviz topics for the camera5 were actually referring to camera0 making it look like calibration was not working

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.
[ ] The PR has been properly tested.
[ ] The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

knzo25 commented 2 years ago

@yabuta It seems that PRs are not blocked by reviews. Is that Ok?