refactor: use trajectory data - Githubissues

tier4 / CalibrationTools

sensor calibration tools for autonomous driving and robotics

GNU General Public License v3.0

121 stars 44 forks source link

refactor: use trajectory data #61

Closed kminoda closed 1 year ago

kminoda commented 1 year ago

Signed-off-by: kminoda koji.minoda@tier4.jp

Description

Refactor deviation_estimator for further development

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.
[ ] The PR has been properly tested.
[ ] The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

kminoda commented 1 year ago

I cannot merge somehow even though all the required CI passes with approved review... :thinking: Let me close this PR and open a new one.