tier4 / edge-auto-jetson

https://sensor.tier4.jp
Apache License 2.0
13 stars 10 forks source link

fix(docker/run.sh): execute command from string #7

Closed aohsato closed 1 year ago

aohsato commented 1 year ago

Signed-off-by: Akihito OHSATO aohsato@gmail.com

Description

[HOTFIX] docker/run.sh was changed to execute a string type by shellcheck, but it couldn't be interpreted.

Current behavior

$ ./docker/run_colcon_build.sh 
Building ROS packages in container
xhost:  unable to open display ""
sourcing   /opt/ros/galactic/install/setup.bash
ROS_ROOT   /opt/ros/galactic
ROS_DISTRO galactic
/ros_entrypoint.sh: line 11: exec: colcon build --symlink-install --packages-up-to perception_ecu_launch: not found

Behavior after this fix

$ ./docker/run_colcon_build.sh 
Building ROS packages in container
xhost:  unable to open display ""
sourcing   /opt/ros/galactic/install/setup.bash
ROS_ROOT   /opt/ros/galactic
ROS_DISTRO galactic
Starting >>> autoware_lint_common
Starting >>> autoware_auto_geometry_msgs
Starting >>> compressed_depth_image_transport
...

Related links

https://github.com/tier4/perception_ecu_container/pull/1/commits/b753b8091afbe287eecc578fc25b82c54879efd2

Tests performed

Execute Building ROS workspace step in this README. https://github.com/tier4/perception_ecu_container/blob/main/README.md

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

After all checkboxes are checked, anyone who has write access can merge the PR.