build(continental_msgs): fix dependencies - Githubissues

tier4 / nebula

A universal LiDAR and radar driver for ROS 2, supporting Hesai, Velodyne, Robosense and Continental sensors.

https://tier4.github.io/nebula/

Apache License 2.0

51 stars 51 forks source link

build(continental_msgs): fix dependencies #140

Closed esteve closed 7 months ago

esteve commented 7 months ago

PR Type

Bug Fix

Related Links

ament_cmake_auto is use in CMakeLists.txt but not declared as a dependency in package.xml

Description

Add ament_cmake_auto to package.xml

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

[ ] Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

[ ] Commits are properly organized and messages are according to the guideline
[ ] (Optional) Unit tests have been written for new behavior
[ ] PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

[ ] All open points are addressed and tracked via issues or tickets

CI Checks

Build and test for PR: Required to pass before the merge.

esteve commented 7 months ago

@knzo25 @xmfcx @mitsudome-r please review this PR when you have a moment, the autoware-deb-packages CI (https://github.com/autowarefoundation/autoware-deb-packages/actions/runs/8696242137/job/23849118285?pr=83) won't build without this change. Thanks.