tier4 / nebula

A universal LiDAR and radar driver for ROS 2, supporting Hesai, Velodyne, Robosense and Continental sensors.
https://tier4.github.io/nebula/
Apache License 2.0
51 stars 51 forks source link

chore: fix pre-commit config and adapt code to make all checks pass #162

Closed mojomex closed 4 months ago

mojomex commented 5 months ago

PR Type

Description

This PR is a preliminary step to

and makes pre-commit pass on the current codebase. This involved:

pre-commit is now passing.

Review Procedure

Make sure to check "hide whitespace" and click apply/reload in the "changed files" view's settings when reviewing:

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

CI Checks

codecov-commenter commented 5 months ago

Codecov Report

Attention: Patch coverage is 5.17241% with 55 lines in your changes missing coverage. Please review.

Please upload report for BASE (develop@46171bf). Learn more about missing BASE report.

Files Patch % Lines
nebula_ros/src/robosense/decoder_wrapper.cpp 0.00% 32 Missing :warning:
...src/nebula_decoders_robosense/robosense_driver.cpp 0.00% 4 Missing :warning:
nebula_ros/src/hesai/hesai_ros_wrapper.cpp 0.00% 3 Missing :warning:
...s/nebula_decoders_robosense/decoders/bpearl_v3.hpp 0.00% 2 Missing :warning:
...s/nebula_decoders_robosense/decoders/bpearl_v4.hpp 0.00% 2 Missing :warning:
...ders/nebula_decoders_robosense/decoders/helios.hpp 0.00% 2 Missing :warning:
...a_decoders_robosense/decoders/robosense_packet.hpp 0.00% 2 Missing :warning:
nebula_ros/src/robosense/robosense_ros_wrapper.cpp 0.00% 2 Missing :warning:
nebula_ros/src/velodyne/velodyne_ros_wrapper.cpp 0.00% 2 Missing :warning:
nebula_common/src/nebula_common.cpp 0.00% 1 Missing :warning:
... and 3 more

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #162 +/- ## ========================================== Coverage ? 14.13% ========================================== Files ? 82 Lines ? 7585 Branches ? 1179 ========================================== Hits ? 1072 Misses ? 5679 Partials ? 834 ``` | [Flag](https://app.codecov.io/gh/tier4/nebula/pull/162/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tier4) | Coverage Δ | | |---|---|---| | [differential](https://app.codecov.io/gh/tier4/nebula/pull/162/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tier4) | `14.13% <5.17%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tier4#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.