tier4 / nebula

A universal LiDAR and radar driver for ROS 2, supporting Hesai, Velodyne, Robosense and Continental sensors.
https://tier4.github.io/nebula/
Apache License 2.0
55 stars 53 forks source link

chore: remove legacy pointcloud topics and point types #198

Closed mojomex closed 3 weeks ago

mojomex commented 2 months ago

PR Type

Description

The PointXYZIR and PointXYZIRADT types are not used by Autoware anymore and are obsolete. Remove their

Review Procedure

Confirm Nebula works with Autoware even when these topics are removed. This does not need a build/launch: confirming that the topics are not used is enough.

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

CI Checks

knzo25 commented 2 months ago

@mojomex (cc: @drwnz )

Outside autoware, having the classic XYZI (I as a float) is quite standard. Would you prefer explicitly dropping compatibility with all non-autoware packages?

drwnz commented 2 months ago

@mojomex (cc: @drwnz )

Outside autoware, having the classic XYZI (I as a float) is quite standard. Would you prefer explicitly dropping compatibility with all non-autoware packages?

Good point Kenzo. Let's include it.