tier4 / nebula

A universal LiDAR and radar driver for ROS 2, supporting Hesai, Velodyne, Robosense and Continental sensors.
https://tier4.github.io/nebula/
Apache License 2.0
47 stars 46 forks source link

chore: fix typos in the SetVelocityVehicle function #204

Open JonasKrug opened 11 hours ago

JonasKrug commented 11 hours ago

PR Type

Description

It fixes the naming of an internal variable in the continental ars548 hardware interface code.

Review Procedure

Check that all occurrences of the misnamed variable were properly replaced.

sonarcloud[bot] commented 11 hours ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 8 hours ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (de9cd6b) to head (738e9fe).

Files with missing lines Patch % Lines
..._hw_interfaces/continental_ars548_hw_interface.cpp 0.00% 1 Missing :warning:

:exclamation: There is a different number of reports uploaded between BASE (de9cd6b) and HEAD (738e9fe). Click for more details.

HEAD has 1 upload less than BASE | Flag | BASE (de9cd6b) | HEAD (738e9fe) | |------|------|------| |total|1|0|
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #204 +/- ## ========================================== - Coverage 25.75% 0.00% -25.76% ========================================== Files 99 86 -13 Lines 8757 7637 -1120 Branches 2173 895 -1278 ========================================== - Hits 2255 0 -2255 - Misses 6115 7637 +1522 + Partials 387 0 -387 ``` | [Flag](https://app.codecov.io/gh/tier4/nebula/pull/204/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tier4) | Coverage Δ | | |---|---|---| | [differential](https://app.codecov.io/gh/tier4/nebula/pull/204/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tier4) | `0.00% <0.00%> (?)` | | | [total](https://app.codecov.io/gh/tier4/nebula/pull/204/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tier4) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tier4#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.