Closed mojomex closed 3 weeks ago
Attention: Patch coverage is 0%
with 14 lines
in your changes missing coverage. Please review.
Project coverage is 26.07%. Comparing base (
214373a
) to head (b1d7a7c
). Report is 2 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
nebula_ros/src/robosense/robosense_ros_wrapper.cpp | 0.00% | 14 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
PR Type
Related Links
147 -- bug introduced here
Description
Since Nebula v0.2.0, or more specifically, since PR #147, DIFOP ("info") packets are not recorded/replayed anymore by Nebula. This made diagnosing https://github.com/orgs/autowarefoundation/discussions/5378 impossible since the sensor configuration was not recorded.
Review Procedure
Remarks
Tested with the Helios PCAP from here.
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks