tier4 / nebula

A universal LiDAR and radar driver for ROS 2, supporting Hesai, Velodyne, Robosense and Continental sensors.
https://tier4.github.io/nebula/
Apache License 2.0
55 stars 53 forks source link

fix(robosense): include DIFOP packets in record/replay functionality #213

Closed mojomex closed 3 weeks ago

mojomex commented 3 weeks ago

PR Type

Related Links

Description

Since Nebula v0.2.0, or more specifically, since PR #147, DIFOP ("info") packets are not recorded/replayed anymore by Nebula. This made diagnosing https://github.com/orgs/autowarefoundation/discussions/5378 impossible since the sensor configuration was not recorded.

Review Procedure

Remarks

Tested with the Helios PCAP from here.

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

CI Checks

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 26.07%. Comparing base (214373a) to head (b1d7a7c). Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
nebula_ros/src/robosense/robosense_ros_wrapper.cpp 0.00% 14 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #213 +/- ## ========================================== + Coverage 25.88% 26.07% +0.18% ========================================== Files 99 99 Lines 9190 9113 -77 Branches 2211 2187 -24 ========================================== - Hits 2379 2376 -3 + Misses 6426 6353 -73 + Partials 385 384 -1 ``` | [Flag](https://app.codecov.io/gh/tier4/nebula/pull/213/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tier4) | Coverage Δ | | |---|---|---| | [differential](https://app.codecov.io/gh/tier4/nebula/pull/213/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tier4) | `26.07% <0.00%> (?)` | | | [total](https://app.codecov.io/gh/tier4/nebula/pull/213/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tier4) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tier4#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.