Open mojomex opened 4 days ago
Attention: Patch coverage is 50.83333%
with 177 lines
in your changes missing coverage. Please review.
Project coverage is 27.52%. Comparing base (
47efeed
) to head (81ad961
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
PR Type
Related Links
233 -- has to be merged before this
232 -- has to be merged before this
231 -- has to be merged before this
Description
:warning: #231, #232, #233 have to be merged before this :warning:
Previously, testing Nebula's HW interfaces has been difficult because all hardware drivers were hard-coded. This meant that during test time, a real network connection would have to be used, or, that
LD_PRELOAD
or macro trickery had to be used.This PR adds a dependency-injectable TCP socket implementation (currently just a wrapper around
transport_drivers
), which allows mocking the TCP socket at test time.Since the TCP socket is still very Hesai-specific, I have added the new socket and refactored it into
nebula_ros
andnebula_hw_interfaces_hesai
already.Basic unit tests to prove testability have been added. More will be added in a future PR.
Review Procedure
Remarks
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks