tier4 / ros2_v4l2_camera

Forked from https://gitlab.com/boldhearts/ros2_v4l2_camera
Apache License 2.0
40 stars 17 forks source link

feat(launch): adding v4l2 buffer timestamp and image_transport options to launch file #22

Closed Owen-Liuyuxuan closed 2 months ago

Owen-Liuyuxuan commented 2 months ago

Description

We have PR https://github.com/tier4/ros2_v4l2_camera/pull/9 introducing use_v4l2_buffer_timestamps flag into the node and PR https://github.com/tier4/ros2_v4l2_camera/pull/14 introducing use_image_transport flag into the node. But They do not appear in the launch file, which could confuse users.

Owen-Liuyuxuan commented 2 months ago

By the way, I think it is not really good that I can directly merge the PR myself.

I will wait for a review first..

Owen-Liuyuxuan commented 2 months ago

Thank you for the review. I updated the documents.