perf: improve utility and overhead - Githubissues

tier4 / sensor_trigger

ROS node for triggering cameras using GPIO on Jetson (targeting ROSCubeX, but easily adaptable to other platforms)

Apache License 2.0

6 stars 3 forks source link

perf: improve utility and overhead #23

Closed manato closed 1 year ago

manato commented 1 year ago

PR Type

Improvement

Related Links

Description

This PR includes two following modifications:

Accepting run time argument to set pulse width in milliseconds
Class-nizing jetson_gpio that has file descriptors as members so that multiple times file opening/closing can be avoided

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

[x] Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

[ ] Commits are properly organized and messages are according to the guideline
[ ] (Optional) Unit tests have been written for new behavior
[ ] PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

[ ] All open points are addressed and tracked via issues or tickets

CI Checks

Build and test for PR: Required to pass before the merge.

drwnz commented 1 year ago

LGTM!