search

tierpod / dmarc-report-converter

Convert dmarc reports from xml to human-readable formats
MIT License
242 stars 25 forks source link

Convert to Bootstrap 5.2 #27

Closed hdholm closed 2 years ago

hdholm commented 2 years ago

At least for me, these changes to the template in consts.go (changing some badge styles) is all that's needed to update to Bootstrap 5.2. The pull also includes the updated assets files from Bootstrap and removes the jquery js file which is no longer a Bootstrap dependency in 5.0+.

tierpod commented 2 years ago

Hello @hdholm ! Thank you for your contribution!

I tool a look on your PR. It looks good, but could you please revert jquery-3.3.1.min.js? It is needed for displaying fancy charts on the top of the page with ChartsJS ("messages count per hostnames" and "pass/fail messages") in consts.go htmlTmpl template.

Also, I would like to know, is there a reason why you chose html output format (loads assets like bootstrap.css from self-hosted web server) instead of html_static output format (loads bootstrap.css from bootstrap cdn)?

I'm asking because I wanted to deprecate html output format and drop css and js dependencies from repo (in favor of html_static format as example and external_template as more flexible way to make new customized templates).

hdholm commented 2 years ago

Sorry about the jquery. I didn't catch that. I'm using this on an internal network where access to the Internet is often, but not always available, and so I used html since I didn't want the page rendering dependent on an external server.

tierpod commented 2 years ago

@hdholm ok, I merged this PR and going to make new release soon. Thank you again!

I didn't want the page rendering dependent on an external server

Got it, I'll keep html output for now (though it can be done via external_template)