search

tierpod / dmarc-report-converter

Convert dmarc reports from xml to human-readable formats
MIT License
237 stars 25 forks source link

Print error message when trying to save in a non-writable directory #29

Closed bwildenhain closed 1 year ago

bwildenhain commented 2 years ago

Currently, dmarc-report-converter silenty fails when trying to write to a directory where it is not allowed to write to.

tierpod commented 1 year ago

Hi @bwildenhain !

Thank you for your contribution! You are absolutely right, this is a bug.

Actually, I think it would be better to return error in this function, not log it (you can see example in the next block https://github.com/tierpod/dmarc-report-converter/blob/1da62a63539c699ef135027eed4041e0e641ad0a/cmd/dmarc-report-converter/output.go#L46-L48

Could you please update you PR?