tierpod / dmarc-report-converter

Convert dmarc reports from xml to human-readable formats
MIT License
241 stars 25 forks source link

incorrect parsing Auth results DKIM #45

Open incous opened 8 months ago

incous commented 8 months ago

It happen for not parsing the correct DKIM Auth Result as the message may got multiple DKIM signatures. Example:

<auth_results>
  <dkim>
    <domain>[domain1]</domain>
    <result>pass</result>
    <selector>select1</selector>
  </dkim>
  <dkim>
    <domain>[domain2]</domain>
    <result>fail</result>
    <selector>selector2</selector>
  </dkim>
  <spf>
    <domain>[domain1]</domain>
    <result>pass</result>
  </spf>
</auth_results>

I got this, and the parsed HTML show this entry as DKIM auth fail, SPF auth pass, but DMARC still pass for DKIM & SPF

tierpod commented 7 months ago

Hi @incous,

I merged PR that should fix this problem yesterday. I'm going to make a new release soon. It would be nice if you could build dmart-report-converter from master branch and do some tests.

Thank you