tierra / topicsolved

phpBB Topic Solved extension: Allows posting questions, and accepting answers as solved.
https://www.phpbb.com/customise/db/extension/topic_solved/
GNU General Public License v2.0
23 stars 19 forks source link

Incompatibility with phpBB 3.3.0 #71

Open notsoencrypted opened 4 years ago

notsoencrypted commented 4 years ago

Just updated to the new version of PHPBB, and unfortunately, this extension broke with the update. It's a super useful one for my RPG group, so I'd love to see an update.

image

Hippie459MN commented 4 years ago

I am getting the same issue and would love to see this updated to 3.3.0.

aberkvam commented 4 years ago

The fix for that error message is pretty trivial. You just need to add quotes around any values that start with @ in that listed file. That gets rid of the error. The extension seems to work for me under phpBB3 with these changes. Not sure if other compatibility fixes are needed.

Changes to ext/tierra/topicsolved/config/services.yml:

5c5
<             - @tierra.topicsolved.topicsolved
---
>             - "@tierra.topicsolved.topicsolved"
9,11c9,11
<             - @tierra.topicsolved.topicsolved
<             - @controller.helper
<             - @template
---
>             - "@tierra.topicsolved.topicsolved"
>             - "@controller.helper"
>             - "@template"
17,19c17,19
<             - @tierra.topicsolved.topicsolved
<             - @template
<             - @request
---
>             - "@tierra.topicsolved.topicsolved"
>             - "@template"
>             - "@request"
25,30c25,30
<             - @dbal.conn
<             - @user
<             - @auth
<             - @dispatcher
<             - %core.root_path%
<             - %core.php_ext%
---
>             - "@dbal.conn"
>             - "@user"
>             - "@auth"
>             - "@dispatcher"
>             - "%core.root_path%"
>             - "%core.php_ext%"
Galixte commented 4 years ago

Hi @tierra,

could you update your extension? Or do you want I submit a new PR for that?

Regards.

philmusic39 commented 4 years ago

Bonjour dommage , c'est une extension des plus pratique dans mon forum. j'ai fait la modification , vider le cache , mais il n'y a pas de changement. je suis en phpbb 3.3.0. Y a t-il une autre astuce que je ne vois pas. Merci pour votre soutien.

Galixte commented 4 years ago

Bonjour dommage , c'est une extension des plus pratique dans mon forum. j'ai fait la modification , vider le cache , mais il n'y a pas de changement. je suis en phpbb 3.3.0. Y a t-il une autre astuce que je ne vois pas. Merci pour votre soutien.

Take a look, here: https://www.phpbb.com/customise/db/extension/topic_solved/support/topic/215181?p=754206#p754206. ;)

philmusic39 commented 4 years ago

Merci Galixe . j'ai re-installé , modifier et tout fonctionne. Je suis ravi , vous faites un excellent travail. bonne continuation et protéger vous bien .

Galixte commented 4 years ago

Take care too. ;)

rmcgirr83 commented 4 years ago
"@dbal.conn"

This is incorrect you don't want double quotes, you want single quotes.

Galixte commented 4 years ago
"@dbal.conn"

This is incorrect you don't want double quotes, you want single quotes.

Thanks, PR submitted: https://github.com/tierra/topicsolved/pull/74.

boczpeter commented 3 years ago

Is this repo abandoned? Why is PR#1 not yet accepted and the ext updated to work with current stable phpbb?

gremirarunico commented 2 years ago

This Issue shouldn't have been solved with this commit https://github.com/tierra/topicsolved/commit/531c116746e05b4636b9cba1a4da78ec68ef57b8 by @Galixte ?