search

tierrif / chat-utils

Minecraft Fabric client-side mod to ease chat message copying.
https://modrinth.com/mod/chatutils/
GNU Lesser General Public License v3.0
17 stars 6 forks source link

Attempting to copy chat freezes client #22

Closed glacialvitality closed 12 months ago

glacialvitality commented 1 year ago

When trying to right-click on a chat message, the game will freeze.

tierrif commented 1 year ago

Please give us more details as this cannot be reproduced under my circumstances. The following information will be useful:

Thanks.

QarthO commented 12 months ago

I'm having the same issue. After clicking on a chat message, the client freezes and it requires me to restart the game completely.

This is the error in the console: [Render thread/ERROR]: Not allowed to run command with signed argument from click event: '/chatmacros hi'

I tried creating an empty instance with just the base mods and nothing else and it still crashes.

Using MultiMC:

Mods:

Running on MacOS Ventura 13.4.1

Things to note, the text does actually copy to my clipboard. But the game crashes 😔

tierrif commented 12 months ago

Thanks for the info. Are you running the game in multiplayer or singleplayer? If in multiplayer, does this happen with any kind of message? Does it still happen in other servers?

QarthO commented 12 months ago

Hi! I’m having this issue in both multiplayer and in single player. The error is the same.

The message I sent was just “hi”

No special format or anything

tierrif commented 12 months ago

Can't reproduce under:

OS: Ubuntu 23.04 x86_64 Minecraft: 1.20.1 Fabric Loader: 0.14.21 ChatUtils: 1.9.1+1.20.1 Cloth Config API: 11.1.106 Fabric API: 0.85.0+1.20.1 Mod Menu: 7.1.0

Using MultiMC or not, the results were the same.

This did not happen to me under Windows either, so the only possibility left is MacOS, unless I'm missing something. If somebody else using MacOS could test this under these exact versions, I'd be grateful. Thanks in advance.

tierrif commented 12 months ago

I looked at logs, and the log you mentioned does show up, but it doesn't crash due to it. So this is definitely not the reason why the client is crashing: [19:19:50] [Render thread/ERROR] (Minecraft) Not allowed to run command with signed argument from click event:

tierrif commented 12 months ago

26 could fix this, just awaiting code review. The changes include a complete rewrite on the click events which should change the logic behind the crash and also uses Minecraft's own copy to clipboard method which should also fix problems caused by Java's simpler method.

Once something is out I will update this issue - would be nice if someone who could reproduce these issues in the past tested the mod again.

tierrif commented 12 months ago

Someone who can reproduce this please test 1.10.0+1.20.1 and see if you can still reproduce the same issue. Thanks.

https://github.com/tierrif/chat-utils/releases/tag/1.10.0%2B1.20.1

QarthO commented 12 months ago

Hey! I updated and tested this on my machine that was freezing before the update... and it worked! This is great! Thanks so much for fixing it. Great response time too. I've got some other things with the new keybind, but ill create a new issue since this one is now solved

tierrif commented 12 months ago

I'm happy it got fixed. As the OP didn't comment on this for a while, I will close this.