search

tierrif / chat-utils

Minecraft Fabric client-side mod to ease chat message copying.
https://modrinth.com/mod/chatutils/
GNU Lesser General Public License v3.0
17 stars 6 forks source link

Feature requests - long chat history; ability to disable copy popup/sound; ability to change copy button #24

Open Fluboxer opened 1 year ago

Fluboxer commented 1 year ago

not sure if this is where feature requests go (nor did I even submitted one), but in other mods those are right in issues so here we go

  1. Longer chat history Self-explanatory. There are separate mods that do that, but since ChatUtils comes with persistent chat history, not having that is kinda unexpected and "literally unplayable" in top of that - why have extra entities when one big mod can do it all?
  2. Ability to disable copy popip/sound You CAN disable/change tooltip that appears when you hover over message in order to copy it, but for some reason you can't disable "pop-up notification" in corner of a screen (I forgor how they called) nor can you change/disable sound
  3. Ability to change button that you press to copy message Just plain left-click is sometimes used when interacting with chat. Maybe adding switch that let's you do same thing, but with right click or shift+LB will make it better?

Even without all those changes this is a great mod that gets thing done, but with those features it will be better

tierrif commented 12 months ago
  1. This should hopefully be simple to implement, by just enlarging the message list, if that's how it works. Needs looking into. When added, a configuration entry will be added to increase/decrease the message history limit;
  2. Easy to implement;
  3. Harder to implement as the left click "feature" is a bit of a hardcoded thing by Minecraft, so that'd require digging into the ChatHUD click events a little to implement a custom version of this, but it shouldn't be too big of a headache. This is something I've had in my TODOs for a while now.

If anyone is willing to contribute I'm more than happy to merge PRs, but it'd also be nice to know what's on the works so we don't do double the work here. Thanks for the feature requests, they're all good ideas.

tierrif commented 12 months ago

2 and 3 implemented under 1.10.0+1.20.1, 1 will have to wait a while

Fluboxer commented 11 months ago

I tested new version (and filled #28 and #29 ) and 3rd issue is what I want to talk in this issue as it is related It mostly works, but it still unable to "break trough" original click action if is it presented

For example, clicking on message executes a command that opens GUI - and if it is the case, it is still executed even if you just wanted to copy message (I just tested and it does copy message if #28 not interfering)

tierrif commented 11 months ago

That makes things more clear, I didn't know your intention was to actually prioritize ChatUtils when attempting to copy a message. This becomes a problem if users disable the extra keybind feature, but I can arrange a fix by simply removing the priority when that setting is enabled. This will be added alongside the fix of your other bug reports.