tierrif / chat-utils

Minecraft Fabric client-side mod to ease chat message copying.
https://modrinth.com/mod/chatutils/
GNU Lesser General Public License v3.0
17 stars 9 forks source link

Cast exception when copying some messages (1.10.1+1.20.1 specific) #40

Open Riftlight opened 11 months ago

Riftlight commented 11 months ago

Crash when using ClientCommands. To replicate the crash:

  1. A normal command (/cglow block (coords) will not crash on its own, but it will crash if you use the chat click event from /cfindblock. This is the main issue.
  2. Crash

Expected: Not crash / have the command work.

Info:

Crash log for chat click: crash-2023-10-25_17.54.42-client.txt

Note: while i was writing this, /clook also caused a crash when using it with this mod. Without having changed anything it suddenly doesn't.

tierrif commented 11 months ago

After reading the crash report this is a problem that isn't related to any mods but with a bug in the mod which I think should be fixed in 1.20.2. If you could see if you can still reproduce this in 1.20.2 with the newest ChatUtils version I'd be grateful.

Riftlight commented 11 months ago

1.20.2 does indeed seem to work. Notably, i crashed one time when im pretty sure i clicked the message, but was unable to replicate. Heres the crash log regardless: crash-2023-10-25_18.18.40-client.txt

tierrif commented 11 months ago

That crash seems to be a Continuity bug, not related to ChatUtils. Would you be needing me to add this fix to 1.20.1? Only asking to know if you really need support for that version in specific as I don't tend to support older versions.

Riftlight commented 11 months ago

Got it, ill ignore it then. I would really appreciate if you added it to 1.20.1, as i use both your mod and clientcommands very often and play solely on that version. If it's too much work, however, don't worry about it.

tierrif commented 11 months ago

A cast exception is happening since a fix for it was only added in 1.20.2, so in a nutshell this issue is about porting 1.10.2+1.20.2's fixes into 1.10.1 (1.20.1)