search

ties / compal_CH7465LG_py

Python interface for the Ziggo Connect Box/Compal CH7465LG
MIT License
116 stars 19 forks source link

Feature/wifi update #19

Closed chefsichter closed 4 years ago

chefsichter commented 4 years ago

Hey Ties

I've think i could solve the problem with the wifi settings. With git i'm fairly new, so tell me, if i do something completely wrong. I made now a feature branch, as far as i read/viewed it's the way to do it?

Btw: I should visit Amsterdam again. Was there like ca. 10 years ago. Loved it :). Do you recommend some other friendly places in the Netherlands?

best regards Felix

ties commented 4 years ago

Hi Felix,

Your feature branch looks good! This is a nice addition. I hope to have time to review it tonight.

Some of the linter checks are not passing right now. You can run them locally using pre-commit, which should also fix the style, but otherwise I'll add a commit to this pr.

ties commented 4 years ago

I did not have time yesterday but I found some today 🙂. It looks good! This is a nice pull request on a feature branch, thanks for the contribution!

I'll merge it and do fixed to satisfy the linter myself.

I think there are quite a few nice places in the Netherlands. I like Utrecht myself (and somehow I'm not too sold on Amsterdam) but many of the older cities are worth a visit!

ties commented 4 years ago

I released v0.2.0 which contains this feature 👍