ties / compal_CH7465LG_py

Python interface for the Ziggo Connect Box/Compal CH7465LG
MIT License
116 stars 19 forks source link

Support to read and update wifi guest network settings #23

Closed frimtec closed 3 years ago

frimtec commented 3 years ago

Dear @ties

Thanks a lot for the useful compal library.

The only thing I'm missing, is the possibility to update wifi guest network settings. I implemented the feature and tested it with my compal modem.

It would be very nice if you could integrate this feature into your library.

If there are issues with my python style, please forgive me, this is my first python code ;-)

Best regards, Markus

frimtec commented 3 years ago

Sorry I have no clue why these tests are failing - sorry, my python knowledge gap. If you could give me a hint, I fix it.

ties commented 3 years ago

I can also help you fix the linter issues, just let me know :)

frimtec commented 3 years ago

Many thank for your valuable comments. I have changed all mentioned points.

But I have no idea why the tests still fail. I fixed all the reported linter errors, but somehow the tests are still red :-(

Can you help?

Many thanks and reagrds, Markus

ties commented 3 years ago

I'll take a look tonight! :)

ties commented 3 years ago

I ran an autoformat (with black) and it passed. Thanks for the contribution!

frimtec commented 3 years ago

Many thanks for accepting my change.