gy-lehel
commented
7 years ago Closed gy-lehel closed 5 years ago
gy-lehel
commented
7 years ago 
natanojl
commented
5 years ago It seems quite obvious that it's a bug in Pidgin: https://bitbucket.org/pidgin/main/src/0b7a0190d83db173f80755c2d6267b0811cc07eb/pidgin/gtkwebview.c?at=default&fileviewer=file-view-default#gtkwebview.c-766.
That line should be link_node = webkit_dom_node_get_parent_node(link_node);
This was introduced in https://bitbucket.org/pidgin/main/commits/247f6f06531ffc0d44bcb343b92d7640de42fce9.
natanojl
commented
5 years ago The fix was merged upstream in https://bitbucket.org/pidgin/main/commits/c23dfca4eb405d240988a16f8a949ac7f51a6a88.
gy-lehel
commented
5 years ago Would it be possible to publish a build with this fix in the ppa? Last build seem to have been done in june.
xhaakon
commented
5 years ago @gy-lehel Would upgrading to Ubuntu 18.04 be an option for you? sipe-collab PPA for 18.04 uses Pidgin 2.12 from the official Ubuntu repository, which doesn't have this bug.
I certainly can update the Pidgin 3 package, just want to make sure maintaining the legacy PPAs (for anything older than 18.04) is worth the while.
gy-lehel
commented
5 years ago Hi
Unfortunately the update for bionic is not possible, because the OS is maintained by the company, and it will take some more time to integrate the new major release (and even after that a lot of colleagues will be loath to switch version). Looking at the commit, it seems, that the patch is already available in main branch, which is the dev for version 3, or am I mistaken?
BR Lehel
xhaakon
commented
5 years ago We were discussing how to proceed with pidgin-sipe in Ubuntu 16.04. The conclusion is that the company still needs to support 16.04, but we see Pidgin 3 as a dead end and don't want to maintain two largely dissimilar versions of Pidgin in 16.04 and 18.04 PPAs.
So the decision has been made to replace Pidgin 3 in 16.04 PPA with Pidgin 2.12.0, the same version Ubuntu 18.04 official repository has. This should make the maintenance of sipe-collab packages easier in the future. The change will happen by the end of 2018.
Looking at the commit, it seems, that the patch is already available in main branch, which is the dev for version 3, or am I mistaken?
You are right, pulling new changes from Pidgin dev would fix this particular issue, but wouldn't ease the burden of maintaining two Pidgin versions we now have. If we want to support both Ubuntu releases in long term, it's desirable to keep the versions of packages in both PPAs as close to each other as possible, if only because of easier distribution of bug fixes.
gy-lehel
commented
5 years ago That sounds like a solution.
xhaakon
commented
5 years ago So I've finished the switch in 16.04 PPA, which now contains 2.12.0 Pidgin package from official Ubuntu 18.04 repository (rebuilt without any modifications).
Before downgrading to Pidgin 2.12, Pidgin 3.0 packages have to be removed from the system:
sudo apt-get remove pidgin pidgin-data libpurple0When asked, confirm removal of packages that depend on the three listed above - among them will be pidgin-sipe and all pidgin -dev and -dbg packages if you have them installed. Then you are ready to reinstall Pidgin 2 from the PPA:
apt-get update
apt-get install pidgin pidgin-sipeAnd finally you may want to do a regular apt-get upgrade to get the latest libnice and Farstream, which I've also updated in the PPA.
xhaakon
commented
5 years ago Pidgin 2.12 migration has been finished. Closing this ticket.