search

tieto / sipe

A third-party Pidgin plugin for Microsoft Lync/OCS - clone of upstream http://repo.or.cz/w/siplcs.git
GNU General Public License v2.0
129 stars 24 forks source link

Sharing a screen from SIPE to MS SFB only displays a black screen #142

Closed joakim-tjernlund closed 7 years ago

joakim-tjernlund commented 7 years ago

I think this worked at one point but recently the MS SFB user only sees a black screen. Using recent git for both sipe and freedrp

xhaakon commented 7 years ago

This sounds like the regression in FreeRDP I know about. Here's how to fix it:

The latter change isn't in sipe-collab, which still uses older (working) FreeRDP snapshot and also the patch isn't compilable with that version.

joakim-tjernlund commented 7 years ago

YES, the last patch to pidgin-spie did it! (already had the freerdp patch)

Also, recently I tracked down a SEGV in Remmina when sharing screen to a smaller screen. Update to latest freerdp to avoid that.

xhaakon commented 7 years ago

Also, recently I tracked down a SEGV in Remmina when sharing screen to a smaller screen. Update to latest freerdp to avoid that.

Good to know. Did you compile the latest Remmina against the latest FreeRDP? I remember it wasn't possible the last time I tried about a month ago.

The issue is solved, so closing.

joakim-tjernlund commented 7 years ago

Yes, it is fixed now. I just rebuild Remmina git against freerdp git to be sure :)

joakim-tjernlund commented 7 years ago

Oh, any chance to add the fix to lanchpad branch ? Also resync launchpad against upstream pidgin-sipe? BTW, I still build against pidgin 2

xhaakon commented 7 years ago

Also resync launchpad against upstream pidgin-sipe?

I'm rather reluctant to perform bigger changes on sipe-collab nowadays. The packages installable from the PPA are in a quite stable state and updating them would IMO add only little value to the users to justify the risk of breaking some stuff.

Because I can no longer use my working hours for maintaining Sipe, I'd rather invest the time I have left into upstream work and thus getting the changes directly into distributions (hence RDP viewer in 1.22.0), with the ultimate prospect of one day shutting down the PPA and the associated GitHub repos. It was always meant as a temporary area for new features developed in association with Ericsson, but has unfortunately grown bigger than originally expected.

Oh, any chance to add the fix to lanchpad branch ?

This can't be done without FreeRDP update as the patch code doesn't compile against FreeRDP in sipe-collab.

BTW, I still build against pidgin 2

That's completely fine, all important features are backported and should work. Pidgin 3 has its own deal of problems and it appears the upstream development has stalled in past months so I don't expect a stable release anytime soon. Actually, I'm considering reverting my development setup back to Pidgin 2 myself too.

joakim-tjernlund commented 7 years ago

Because I can no longer use my working hours for maintaining Sipe, I'd rather invest the time I have left into upstream work and thus getting the changes directly into distributions (hence RDP viewer in 1.22.0), with the ultimate prospect of one day shutting down the PPA and the associated GitHub repos. It was always meant as a temporary area for new features developed in association with Ericsson, but has unfortunately grown bigger than originally expected.

Any chance this will happen soon? There are a few bug fixes more upstarem so I would love to switch sooner than later :)

xhaakon commented 7 years ago

You may want to try my personal branch here then: https://github.com/xhaakon/sipe/commits/lp-rebase

It contains the patches left in sipe-collab (i.e. mostly the RDP server) on top of the current upstream, which I guess is what you want.

When rebasing the Collab code, I had to do some non-trivial updates to make it apply cleanly onto mainline mob branch and the result isn't very well tested yet, but the basic RDP presenter stuff should work.

joakim-tjernlund commented 7 years ago

I have noted in pidgin 2 that in "Input and Output Settings", Device is always "Default". I cannot change it. Have you seen that too?

xhaakon commented 7 years ago

In Pidgin 2 that in "Input and Output Settings", Device is always "Default".

Yes, media device detection in Pidgin 2 isn't available when Pidgin is built with GStreamer 1.0. I have re-implemented it into Pidgin 3, but the feature is not backported to 2.x.

joakim-tjernlund commented 7 years ago

Any way you can point me to that commit(or backport it) in Pidgin3?

xhaakon commented 7 years ago

Sure, see this pull request on Bitbucket: https://bitbucket.org/pidgin/main/pull-requests/86/gstreamer-10-media-device-management

joakim-tjernlund commented 7 years ago

Ouch, that was quite a big change. Too much for me sort out for to get in into pidgin. Is there some minimal diff that can be applied to pidgin2?

xhaakon commented 7 years ago

Is there some minimal diff that can be applied to pidgin2?

I'm afraid the PR is as minimal as it can get...