tieto / sipe

A third-party Pidgin plugin for Microsoft Lync/OCS - clone of upstream http://repo.or.cz/w/siplcs.git
GNU General Public License v2.0
129 stars 24 forks source link

Please use Pidgin 2.13 #157

Open dwmw2 opened 6 years ago

dwmw2 commented 6 years ago

There should be no need any more to build Pidgin 3.x (which is unlikely to actually be released any time soon). All the features we need are in the 2.12 stable release.

Please update the PPA so that it contains a build of 2.12 (against GStreamer 1.0) and SIPE built against that.

joakim-tjernlund commented 6 years ago

The audio and video selection should be backported from 3.0 though: https://bitbucket.org/pidgin/main/pull-requests/86/gstreamer-10-media-device-management/diff

dwmw2 commented 6 years ago

Hm, yeah. That was done after I'd already backported the rest, it seems. I was hoping that any further changes after I brought them into sync again would continue to be made in both branches.

Looking at it, I think only the first commit b8729e1ecf "mediamanager: add info argument to PurpleMediaElementCreateCallback" would need to be adjusted to avoid breaking the libpurple 2.x ABI. The rest seems OK.

joakim-tjernlund commented 6 years ago

in pidgin 3, pulseaudio went away. PA is the only audio that is fairly stable for me. Using ALSA the microphone stops working just as the call connects.

dwmw2 commented 6 years ago

Note the response on the Pidgin devel mailing list when I brought this up:

Our intent is not to backport stuff to 2.x.y. If it needs to go in 2.x.y it does and is then forward ported into 3.0.0 when we release the 2.x.y version.

All the more reason to be shipping a 2.x-based package in the PPA and working on 2.x. :)

joakim-tjernlund commented 6 years ago

Forgot about this but the above stmt is ridiculous, if they don't want to backport from 3.0.0 they are welcome to reimplement what needs to be fixed in 2.x

dwmw2 commented 6 years ago

The audio and video selection should be backported from 3.0 though:

Done. https://bitbucket.org/pidgin/main/pull-requests/322/media-fixes

joakim-tjernlund commented 6 years ago

Finally got to this, figured I would apply a patch on top 2.13 but I cannot see how to generate a patch from the above PR, do you?

Are you keeping a git tree somewhere as well ?

dwmw2 commented 6 years ago

PR322 is merged now into Pidgin 2.14