search

tiffaneyparis / tiffaneyparis.github.io

0 stars 0 forks source link

Instructor Notification #1

Open tiffaneyparis opened 8 years ago

tiffaneyparis commented 8 years ago

Here is my completed assignment @ianshea

ianshea commented 8 years ago

Hey Tiffaney,

You've got a small issue with your code. Your <p> tags should be nested within your <li> tags.

<li><a href="http://calvinteoh.com/">Calvin Teoh</a></li>
        <p>I enjoy the simple monochromatic style of this site. It's classic, 
        elegant, and not overly complicated. It stays blue throughout, until clicking the links, 
        then it comes to life by adding the proper, vibrant color. </p>

Should be:

<li>
    <a href="http://calvinteoh.com/">Calvin Teoh</a>
    <p>I enjoy the simple monochromatic style of this site. It's classic, elegant, and not overly complicated. It stays blue throughout, until clicking the links, then it comes to life by adding the proper, vibrant color. </p>
</li>

Should be a really quick fix. Nice job!

As for the Fixed Group site, I'm not entirely sure what they're doing with those images. But, best practice is to use correctly licensed images.

There are some things we can do with HTML and CSS that can provide neat effects with scrolling but, manipulating scrolling by going side-to-side or in alternate directions is something that's done by hi-jacking the natural scroll and running javascript to control animations or alter behavior.