search

tiffany352 / rink-rs

Unit conversion tool and library written in rust
https://rinkcalc.app/about
GNU General Public License v3.0
408 stars 28 forks source link

Add an integration test to rink-sandbox #128

Closed tiffany352 closed 2 years ago

tiffany352 commented 2 years ago

I'm having a hard time actually testing this crate because it's pretty much entirely IO. There is an issue where the child process never saves coverage, because it doesn't exit gracefully (by returning from main()). For some reason in the integration test, the child process doesn't ever restart after crashing either, and I'm not sure why. This is a start at least.

codecov[bot] commented 2 years ago

Codecov Report

Merging #128 (d8de05d) into master (07bdee9) will increase coverage by 1.52%. The diff coverage is 65.21%.

@@            Coverage Diff             @@
##           master     #128      +/-   ##
==========================================
+ Coverage   63.66%   65.18%   +1.52%     
==========================================
  Files          55       56       +1     
  Lines       10245    10267      +22     
==========================================
+ Hits         6522     6693     +171     
+ Misses       3723     3574     -149
Impacted Files Coverage Δ
sandbox/integration/main.rs 52.94% <52.94%> (ø)
sandbox/src/lib.rs 15.15% <100.00%> (+11.81%) :arrow_up:
sandbox/src/parent.rs 68.21% <100.00%> (+68.21%) :arrow_up:
core/src/output/number_parts.rs 66.56% <0.00%> (-0.62%) :arrow_down:
sandbox/src/error.rs 4.06% <0.00%> (+0.97%) :arrow_up:
cli/src/config.rs 3.82% <0.00%> (+3.82%) :arrow_up:
sandbox/src/frame.rs 60.00% <0.00%> (+60.00%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 07bdee9...d8de05d. Read the comment docs.