search

tifrueh / conjugator

Verb conjugation trainer
GNU General Public License v3.0
2 stars 0 forks source link

Make sure VerbView gets sized correctly #17

Closed tifrueh closed 6 months ago

tifrueh commented 7 months ago

The configuration of VerbView (wxVScrolledWindow) does not seem to fully work out.

On GTK and macOS (and maybe also on Windows) VerbView gets one additional empty line when scrolled to the absolute bottom. Subtracting 1 when calling SetRowCount solves this problem on GTK. This subtraction makes sense because SetRowCount doesn't actually take the amount of rows as argument, but rather the 0-based index of the last row. See https://docs.wxwidgets.org/stable/classwx_var_v_scroll_helper.html#adcf2e7fa5ea560587a7a1055cf0659ad

But, oddly enough, on macOS about 1.5 rows are removed with this subtraction instead of 1, causing the last line to be clipped.

tifrueh commented 6 months ago

Closed with bcac4943bddd340f86a57ce5084af8fc674094d0...735a395b1265c44dcb2a4f3c72d51c8e8f75c6d8