tig-nl / gls-magento2

Integrate GLS shipping services into Magento 2. Add GLS shipping and parcelshops to your checkout. Create your labels with Track and Trace functionality from the Magento backend.
5 stars 8 forks source link

[BUG] Can't get GLS labels when using re-order #19

Closed vandijkstef closed 2 years ago

vandijkstef commented 3 years ago

To Reproduce Steps to reproduce the behavior:

  1. Create an order that is using GLS as shipping method
  2. Click on 'Re-order' in the admin and set it to use GLS as shipping method
  3. Create a shipment for the new order
  4. Try to retrieve the label, the exception pasted below appears

Expected result Retrieving a GLS label

Actual result

1 exception(s):
Exception #0 (Exception): Notice: Trying to get property 'deliveryAddress' of non-object in /Users/vandijkstef/Web/emaillegigant/web/vendor/tig/gls-magento2/Service/Label/Create.php on line 156

Exception #0 (Exception): Notice: Trying to get property 'deliveryAddress' of non-object in /Users/vandijkstef/Web/emaillegigant/web/vendor/tig/gls-magento2/Service/Label/Create.php on line 156
<pre>#1 TIG\GLS\Service\Label\Create->mapLabelData() called at [vendor/tig/gls-magento2/Service/Label/Create.php:142]
#2 TIG\GLS\Service\Label\Create->getRequestData() called at [vendor/tig/gls-magento2/Controller/Adminhtml/Label/Create.php:83]
#3 TIG\GLS\Controller\Adminhtml\Label\Create->execute() called at [vendor/magento/framework/App/Action/Action.php:108]
#4 Magento\Framework\App\Action\Action->dispatch() called at [vendor/magento/framework/Interception/Interceptor.php:58]
#5 TIG\GLS\Controller\Adminhtml\Label\Create\Interceptor->___callParent() called at [vendor/magento/framework/Interception/Interceptor.php:138]
#6 TIG\GLS\Controller\Adminhtml\Label\Create\Interceptor->Magento\Framework\Interception\{closure}() called at [vendor/magento/framework/Interception/Interceptor.php:153]
#7 TIG\GLS\Controller\Adminhtml\Label\Create\Interceptor->___callPlugins() called at [generated/code/TIG/GLS/Controller/Adminhtml/Label/Create/Interceptor.php:26]
#8 TIG\GLS\Controller\Adminhtml\Label\Create\Interceptor->dispatch() called at [vendor/magento/framework/App/FrontController.php:159]
#9 Magento\Framework\App\FrontController->processRequest() called at [vendor/magento/framework/App/FrontController.php:98]
#10 Magento\Framework\App\FrontController->dispatch() called at [vendor/magento/framework/Interception/Interceptor.php:58]
#11 Magento\Framework\App\FrontController\Interceptor->___callParent() called at [vendor/magento/framework/Interception/Interceptor.php:138]
#12 Magento\Framework\App\FrontController\Interceptor->Magento\Framework\Interception\{closure}() called at [vendor/magento/framework/Interception/Interceptor.php:153]
#13 Magento\Framework\App\FrontController\Interceptor->___callPlugins() called at [generated/code/Magento/Framework/App/FrontController/Interceptor.php:26]
#14 Magento\Framework\App\FrontController\Interceptor->dispatch() called at [vendor/magento/framework/App/Http.php:116]
#15 Magento\Framework\App\Http->launch() called at [vendor/magento/framework/App/Bootstrap.php:261]
#16 Magento\Framework\App\Bootstrap->run() called at [pub/index.php:94]
</pre>

Workaround None

Screenshots None

Please complete the following information

tig-jeffreybranderhorst commented 3 years ago

Hi @vandijkstef ,

Thank you for submitting this issue. We have placed it on our backlog to investigate further and to apply the fix!

Have a great day, Jeffrey