tigase / beagle-im

(M) XMPP client for macOS based on TigaseSwift XMPP library
GNU General Public License v3.0
181 stars 21 forks source link

Renaming a contact does not work #109

Closed nullobsi closed 2 years ago

nullobsi commented 2 years ago

Describe the bug Using Window -> Contacts, right clicking a contact to change their name in the roster does not work.

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Window > Contacts'
  2. Right click contact
  3. Select rename
  4. Input name, enter
  5. Nothing happens

Expected behavior The name change should be reflected

Desktop (please complete the following information):

Additional context The XML console shows that the <iq type="set"> fails because it does not contain an id property

this is with Ejabberd 22.05-1 on Arch Linux as the server

<!--   2022-07-26T23:56:58Z   >>>>   -->
<iq type='set'>
<query xmlns='jabber:iq:roster'>
<item jid='bridge@nullob.si' name='Bridge Acct'/>
</query>
</iq>

<!--   2022-07-26T23:56:58Z   <<<<   -->
<iq type='error'>
<query xmlns='jabber:iq:roster'>
<item jid='bridge@nullob.si' name='Bridge Acct'/>
</query>
<error type='modify'>
<bad-request xmlns='urn:ietf:params:xml:ns:xmpp-stanzas'/>
<text xml:lang='en' xmlns='urn:ietf:params:xml:ns:xmpp-stanzas'>Missing attribute &apos;id&apos; in tag &lt;iq/&gt; qualified by namespace &apos;jabber:client&apos;</text>
</error>
</iq>

<!--   2022-07-26T23:56:58Z   <<<<   -->
<r xmlns='urn:xmpp:sm:3'/>

<!--   2022-07-26T23:56:58Z   >>>>   -->
<a h='140' xmlns='urn:xmpp:sm:3'/>
nullobsi commented 2 years ago

It appears to be working now in the next beta, but I'm not sure what changed. :)