Open lovetox opened 4 years ago
This issue is now fixed with support for requesting no history from the MUC room with maxchars
attribute set to 0
.
As for the maxchars
attribute, I personally feel that it is not needed in current implementations and it should be no longer used. In a time when conversations in MUC rooms can be encrypted with OMEMO, limiting the number of history messages returned by the number of chars of the XML stanza is not in place. I think that clients should be using maxstanzas
or since
attributes to have behavior more suited to the current state of XMPP and MUC.
Hi,
I dont see how encryption has anything to do with the way we request history.
That is the spec, and it especially asks for that behavior
see: https://xmpp.org/extensions/xep-0045.html#enter-managehistory
If the client wishes to receive no history, it MUST set the 'maxchars' attribute to a value of "0" (zero).
I know the spec and I know what is in it. Changes in Tigase were made to match the XEP. I've just pointed out that in my opinion usage of maxchars
is not a great idea in current times.
Looking from the client perspective and the XEP, what is the difference between maxchars
set to 0
and maxstanzas
set to 0
? In both cases, you will get no messages from the room history.
I think its not worth to spend and thought on that.
This is an almost 2 decade old spec, and it has much bigger problems than the attribute name that signales no history.
Anyway thanks for the fast fix :)
@lovetox: It has been solved?
Describe the bug
history preferences are not respected on MUC joins
To Reproduce Steps to reproduce the behavior: