tigase / tigase-muc

Tigase Multi-User Chat Component
https://tigase.net
GNU Affero General Public License v3.0
5 stars 7 forks source link

muc mam seems broken in sure.im #19

Open pravi opened 11 months ago

pravi commented 11 months ago

Describe the bug This was noticed some time back and some discussion happened at https://github.com/xsf/xmpp-providers-website/issues/66#issuecomment-1747382915

To Reproduce Steps to reproduce the behavior:

  1. Create an muc and invite someone
  2. disable the account and ask other person to send messages while offline
  3. enable account and check for offline messages
  4. No offline message or unable to decrypt

Expected behavior offline messages should be visible

Screenshots 8d3b2fc3-826c-4394-809e-fe3603143675

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context

Tried on both monocles chat and gajim (also some other people reported issues earlier)

woj-tek commented 11 months ago

Quick comment:

No offline message or unable to decrypt

Those are two separate things: 1) no offline message would indicate problem with MAM 2) 'unable to decrypt' suggest problem with other clients not retrieving properly encryption keys…

Were you able to reproduce the issue using protocol itself, i.e. https://xmpp.org/extensions/xep-0313.html#query ?

pravi commented 11 months ago

For this query

<iq type='set' id='iyonog'>
  <query xmlns='urn:xmpp:mam:2' queryid='f27' />
</iq>

This was the result

<iq xmlns="jabber:client" to="[jid remove]/gajim.125U1Z4R" id="iyonog" type="result">
  <fin xmlns="urn:xmpp:mam:2" queryid="f27">
    <set xmlns="http://jabber.org/protocol/rsm">
      <count>1069</count>
      <last>5dafa2ca-7b7d-4533-afbc-89e46e12e2bd</last>
      <first>c9f40eb4-73f7-4132-b612-cb806c5c78ae</first>
</set>
</fin>
</iq>
hantu85 commented 11 months ago

Actually, that is a correct response. However, additionally to this <iq/> result there are also separate messages sent with the actual messages being fetched from MUC MAM archive.

The <iq type="result"/> is sent by the server after sending all messages requested by the client, so the MUC MAM responded without any error.

If messages were sent to you or not, we will not know as you have not attached this part of the XMPP stream log.

Additionally, you've request MAM history fetch from your account MAM archive and not the MUC room MAM archive, so you are testing totally different thing.

Neustradamus commented 11 months ago

To follow